Skip to content

skill-creator: default new skills to ~/.codex/skills#14837

Merged
xl-openai merged 2 commits intomainfrom
dev/codex/update-skill-creator-to-set-default-path
Mar 17, 2026
Merged

skill-creator: default new skills to ~/.codex/skills#14837
xl-openai merged 2 commits intomainfrom
dev/codex/update-skill-creator-to-set-default-path

Conversation

@xl-openai
Copy link
Copy Markdown
Collaborator

Motivation

  • Prevent newly-created skills from being placed in unexpected locations by prompting for an install path and defaulting to a discoverable location so skills are usable immediately.
  • Make the skill-creator instructions explicit about the recommended default (~/.codex/skills / $CODEX_HOME/skills) so the agent and users follow a consistent, discoverable convention.

Description

  • Updated codex-rs/skills/src/assets/samples/skill-creator/SKILL.md to add a user prompt: "Where should I create this skill? If you do not have a preference, I will place it in ~/.codex/skills so Codex can discover it automatically.".
  • Added guidance before running init_skill.py that if the user does not specify a location, the agent should default to ~/.codex/skills (equivalently $CODEX_HOME/skills) for auto-discovery.
  • Updated the init_skill.py examples in the same SKILL.md to use ~/.codex/skills as the recommended default while keeping one custom path example.

Testing

  • Ran cargo test -p codex-skills and the crate's unit test suite passed (1 passed; 0 failed).
  • Verified relevant discovery behavior in code by checking codex-rs/utils/home-dir/src/lib.rs (find_codex_home defaults to ~/.codex) and codex-rs/core/src/skills/loader.rs (user skill roots include $CODEX_HOME/skills).

Codex Task

@xl-openai xl-openai added the codex Label used by connector to tag PRs that have been reviewed by Codex label Mar 16, 2026 — with ChatGPT Codex Connector
@xl-openai xl-openai requested a review from gverma-openai March 16, 2026 18:48
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ec95126df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


Skip this step only if the skill being developed already exists. In this case, continue to the next step.

Before running `init_skill.py`, ask where the user wants the skill created. If they do not specify a location, default to `~/.codex/skills` (equivalently `$CODEX_HOME/skills`) so the skill is auto-discovered.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve default skill path from CODEX_HOME

Do not treat ~/.codex/skills as equivalent to $CODEX_HOME/skills. If a user sets CODEX_HOME to a custom directory, this instruction creates skills in a different location that may not be auto-discovered. The default guidance should derive from CODEX_HOME (or explicitly fall back to ~/.codex) instead of hardcoding ~/.codex/skills.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex fix this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Testing

  • cargo test -p codex-skills
  • ⚠️ python - <<'PY' ... urllib.request.urlopen('https://duckduckgo.com/html/?q=...') ... PY (web search attempt failed in this environment with 403 Forbidden)
  • ⚠️ curl -fsSL 'https://r.jina.ai/http://duckduckgo.com/?q=bash+parameter+expansion+default+value+unset' | head -n 40 (web search proxy returned 403)

View task →

@xl-openai xl-openai merged commit 59533a2 into main Mar 17, 2026
32 checks passed
@xl-openai xl-openai deleted the dev/codex/update-skill-creator-to-set-default-path branch March 17, 2026 01:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

codex Label used by connector to tag PRs that have been reviewed by Codex

2 participants