Fix agent jobs finalization race and reduce status polling churn#14843
Merged
daveaitel-openai merged 1 commit intomainfrom Mar 17, 2026
Merged
Fix agent jobs finalization race and reduce status polling churn#14843daveaitel-openai merged 1 commit intomainfrom
daveaitel-openai merged 1 commit intomainfrom
Conversation
jif-oai
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
report_agent_job_resultatomically transition an item from running to completed while storingresult_jsonWhy
This addresses the race and polling concerns in #13948 by removing timing-based correctness assumptions and reducing unnecessary status polling churn.
Validation
cd codex-rs && just fmtcd codex-rs && cargo test -p codex-statecd codex-rs && cargo test -p codex-core --test all suite::agent_jobscd codex-rs && cargo testmessage_processor::tracing_tests::thread_start_jsonrpc_span_exports_server_span_and_parents_childrentimed out waiting for responseNotes
main.Fixes #13948