[apps][tool_suggest] Remove tool_suggest's dependency on tool search.#14856
Merged
mzeng-openai merged 11 commits intomainfrom Mar 25, 2026
Merged
[apps][tool_suggest] Remove tool_suggest's dependency on tool search.#14856mzeng-openai merged 11 commits intomainfrom
mzeng-openai merged 11 commits intomainfrom
Conversation
Collaborator
mzeng-openai
commented
Mar 16, 2026
mzeng-openai
commented
- Remove tool_suggest's dependency on tool search.
sayan-oai
reviewed
Mar 16, 2026
| Use this ONLY when: | ||
| - There's no available tool to handle the user's request | ||
| - And tool_search fails to find a good match | ||
| - You've already tried to find a matching available tool for the user's request but couldn't find a good match. This includes `tool_search` (if available) and other means. |
Collaborator
There was a problem hiding this comment.
now that tool_search is not always available when tool_suggest is available, i wonder if we should conditionally render the bit about tool_search rather than saying (if available) to avoid confusing the model?
Collaborator
|
in similar fashion to my review comment, should we avoid assuming |
sayan-oai
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.