fix(linux-sandbox): ignore missing writable roots#14890
Merged
viyatb-oai merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
viyatb-oai
force-pushed
the
codex/viyatb/fix-linux-sandbox-missing-writable-roots
branch
from
9c55f33 to
87be430
Compare
viyatb-oai
force-pushed
the
codex/viyatb/fix-linux-sandbox-missing-writable-roots
branch
from
87be430 to
53c6710
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
viyatb-oai
deleted the
codex/viyatb/fix-linux-sandbox-missing-writable-roots
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace-writewritable roots in the Linux bubblewrap mount builder instead of aborting sandbox startupContext
This addresses regression A from #14875. Regression B will be handled in a separate PR.
The old bubblewrap integration added
ensure_mount_targets_existas a preflight guard because bubblewrap bind targets must exist, and failing early let Codex return a clearer error than a lower-level mount failure.That policy turned out to be too strict once bubblewrap became the default Linux sandbox: shared Windows/WSL or mixed-platform configs can legitimately contain a well-formed writable root that does not exist on the current machine. This PR keeps bubblewrap's existing-target requirement, but changes Codex to skip missing writable roots instead of treating them as fatal configuration errors.