Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This reverts commit d69ce58.
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
etraut-openai
approved these changes
Mar 17, 2026
Collaborator
etraut-openai
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Collaborator
Author
Thank you, Eric! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CXC-410 Emit Env Var Status with
/feedbackreportAdd more observability on top of #14611

Unset
Set
Summary
/responses, websocket, and/modelstelemetry and feedback metadata.env_keyconfiguration to a safe"configured"value instead of emitting raw config text.Rationale (from spec findings)
Scope
AuthEnvTelemetrybundle for env presence collection and threads it through the main request/session telemetry paths.Trade-offs
provider_env_key_nameis bucketed to"configured"instead of preserving the literal configured env var name./modelsis included because startup/model-refresh auth failures need the same diagnostics, but broader parity work remains out of scope.Client follow-up
Testing
cargo test -p codex-core emit_feedback_request_tags -- --nocapturecargo test -p codex-core collect_auth_env_telemetry_buckets_provider_env_key_name -- --nocapturecargo test -p codex-core models_request_telemetry_emits_auth_env_feedback_tags_on_failure -- --nocapturecargo test -p codex-otel otel_export_routing_policy_routes_api_request_auth_observability -- --nocapturecargo test -p codex-otel otel_export_routing_policy_routes_websocket_connect_auth_observability -- --nocapturecargo test -p codex-otel otel_export_routing_policy_routes_websocket_request_transport_observability -- --nocapturecargo test -p codex-core --no-run --message-format shortcargo test -p codex-otel --no-run --message-format short