Skip to content

Add device-code onboarding and ChatGPT token refresh to app-server TUI#14952

Merged
etraut-openai merged 3 commits intomainfrom
etraut/device-login-and-token-refresh
Mar 17, 2026
Merged

Add device-code onboarding and ChatGPT token refresh to app-server TUI#14952
etraut-openai merged 3 commits intomainfrom
etraut/device-login-and-token-refresh

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

Summary

  • add device-code ChatGPT sign-in to tui_app_server onboarding and reuse the existing chatgptAuthTokens login path
  • fall back to browser login when device-code auth is unavailable on the server
  • treat ChatgptAuthTokens as an existing signed-in ChatGPT state during onboarding
  • add a local ChatGPT auth loader for handing local tokens to the app server and serving refresh requests
  • handle account/chatgptAuthTokens/refresh instead of marking it unsupported, including workspace/account mismatch checks
  • add focused coverage for onboarding success, existing auth handling, local auth loading, and refresh request behavior

Testing

  • cargo test -p codex-tui-app-server
  • just fix -p codex-tui-app-server
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10d60a37e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai force-pushed the etraut/device-login-and-token-refresh branch from 2377702 to a25fc22 Compare March 17, 2026 17:59
@etraut-openai etraut-openai merged commit 49e7dda into main Mar 17, 2026
33 checks passed
@etraut-openai etraut-openai deleted the etraut/device-login-and-token-refresh branch March 17, 2026 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant