chore: refactor network permissions to use explicit domain and unix socket rule maps by celia-oai · Pull Request #15120 · openai/codex

celia-oai · 2026-03-19T00:32:43Z

Summary

This PR replaces the legacy network allow/deny list model with explicit rule maps for domains and unix sockets across managed requirements, permissions profiles, the network proxy config, and the app server protocol.

Concretely, it:

introduces typed domain (allow / deny) and unix socket permission (allow / none) entries instead of separate allowed_domains, denied_domains, and allow_unix_sockets lists
updates config loading, managed requirements merging, and exec-policy overlays to read and upsert rule entries consistently
exposes the new shape through protocol/schema outputs, debug surfaces, and app-server config APIs
rejects the legacy list-based keys and updates docs/tests to reflect the new config format

Why

The previous representation split related network policy across multiple parallel lists, which made merging and overriding rules harder to reason about. Moving to explicit keyed permission maps gives us a single source of truth per host/socket entry, makes allow/deny precedence clearer, and gives protocol consumers access to the full rule state instead of derived projections only.

Backward Compatibility

Backward compatible

Managed requirements still accept the legacy experimental_network.allowed_domains, experimental_network.denied_domains, and experimental_network.allow_unix_sockets fields. They are normalized into the new canonical domains and unix_sockets maps internally.
App-server v2 still deserializes legacy allowedDomains, deniedDomains, and allowUnixSockets payloads, so older clients can continue reading managed network requirements.
App-server v2 responses still populate allowedDomains, deniedDomains, and allowUnixSockets as legacy compatibility views derived from the canonical maps.
managed_allowed_domains_only keeps the same behavior after normalization. Legacy managed allowlists still participate in the same enforcement path as canonical domains entries.

Not backward compatible

Permissions profiles under [permissions.<profile>.network] no longer accept the legacy list-based keys. Those configs must use the canonical [domains] and [unix_sockets] tables instead of allowed_domains, denied_domains, or allow_unix_sockets.
Managed experimental_network config cannot mix canonical and legacy forms in the same block. For example, domains cannot be combined with allowed_domains or denied_domains, and unix_sockets cannot be combined with allow_unix_sockets.
The canonical format can express explicit "none" entries for unix sockets, but those entries do not round-trip through the legacy compatibility fields because the legacy fields only represent allow/deny lists.

Testing

/target/debug/codex sandbox macos --log-denials /bin/zsh -c 'curl https://www.example.com' gives 200 with config

[permissions.workspace.network.domains]
"www.example.com" = "allow"

and fails when set to deny: curl: (56) CONNECT tunnel failed, response 403.

Also tested backward compatibility path by verifying that adding the following to /etc/codex/requirements.toml works:

[experimental_network]
allowed_domains = ["www.example.com"]

celia-oai · 2026-03-20T00:33:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21117a718a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/network_proxy_spec.rs

codex-rs/core/src/network_proxy_loader.rs

celia-oai · 2026-03-20T01:38:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 626b34b281

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/network_proxy_spec.rs

codex-rs/core/src/network_proxy_loader.rs

celia-oai · 2026-03-20T02:04:52Z

@codex review

celia-oai · 2026-03-26T21:32:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85d53815b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/permissions.rs

codex-rs/config/src/config_requirements.rs

celia-oai · 2026-03-26T22:31:43Z

@codex review

celia-oai · 2026-03-26T22:37:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71c88f94f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/permissions.rs

codex-rs/app-server/src/config_api.rs

viyatb-oai · 2026-03-27T00:44:59Z

codex-rs/config/src/config_requirements.rs

+fn legacy_domain_permissions_from_lists(
+    allowed_domains: Option<Vec<String>>,
+    denied_domains: Option<Vec<String>>,
+) -> Option<NetworkDomainPermissionsToml> {
+    let mut entries = BTreeMap::new();
+
+    for pattern in allowed_domains.unwrap_or_default() {
+        entries.insert(pattern, NetworkDomainPermissionToml::Allow);
+    }
+
+    for pattern in denied_domains.unwrap_or_default() {
+        entries.insert(pattern, NetworkDomainPermissionToml::Deny);
+    }
+
+    (!entries.is_empty()).then_some(NetworkDomainPermissionsToml { entries })
+}
+
+fn legacy_unix_socket_permissions_from_list(
+    allow_unix_sockets: Option<Vec<String>>,
+) -> Option<NetworkUnixSocketPermissionsToml> {
+    let entries = allow_unix_sockets
+        .unwrap_or_default()
+        .into_iter()
+        .map(|path| (path, NetworkUnixSocketPermissionToml::Allow))
+        .collect::<BTreeMap<_, _>>();
+
+    (!entries.is_empty()).then_some(NetworkUnixSocketPermissionsToml { entries })


[P2] Preserve explicit empty legacy network lists

These helpers collapse explicit legacy allowed_domains = [] / allow_unix_sockets = [] to None, which is not equivalent to the old structs. In danger-full-access, allowed_domains = [] used to clear and pin the allowlist to empty, but now it is treated as absent and leaves user allowlist entries intact. Likewise, allow_unix_sockets = [] used to keep dangerously_allow_all_unix_sockets constrained off via constraints.allow_unix_sockets = Some([]), but that constraint now disappears.

there is unfortunately some lossiness expected after migrating to the new schema. I added a docstring here to explain this: https://github.com/openai/codex/pull/15120/changes#diff-6dea1db0d0ce5a6f3b19ccbc66cb916ad15d3bbc8ce347cff9a934445f9ce56eR311-R313

I feel the better thing to do here is to get rid of dangerously_allow_all_unix_sockets down the road, and restrict danger-full-access behavior?

let me take a stab at seeing if we can preserve the behavior

you can land this though and we can do a fast follow

celia-oai force-pushed the dev/cc/refactor branch 12 times, most recently from 6b9473c to 69d6d08 Compare March 19, 2026 23:43

celia-oai changed the title ~~changes~~ Mar 19, 2026

celia-oai changed the title ~~Refactor network permissions to use explicit domain and unix socket rule maps~~ Mar 19, 2026

celia-oai force-pushed the dev/cc/refactor branch 4 times, most recently from df83550 to 21117a7 Compare March 20, 2026 00:30

celia-oai marked this pull request as ready for review March 20, 2026 00:30

celia-oai requested a review from bolinfest March 20, 2026 00:30

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

codex-rs/core/src/config/network_proxy_spec.rs Outdated Show resolved Hide resolved

codex-rs/core/src/config/network_proxy_spec.rs Outdated Show resolved Hide resolved

codex-rs/core/src/network_proxy_loader.rs Outdated Show resolved Hide resolved

celia-oai force-pushed the dev/cc/refactor branch 2 times, most recently from 4353e7b to 626b34b Compare March 20, 2026 01:36

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

codex-rs/core/src/config/network_proxy_spec.rs Outdated Show resolved Hide resolved

codex-rs/core/src/network_proxy_loader.rs Outdated Show resolved Hide resolved

celia-oai force-pushed the dev/cc/refactor branch 2 times, most recently from 79185b4 to 4c42cf4 Compare March 20, 2026 01:58

github-actions bot mentioned this pull request Mar 20, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-20 compasify/agents-radar#60

Open

celia-oai added 4 commits March 26, 2026 13:14

changes

4420fe6

changes

c7615f7

changes

9da9d56

changes

5b59013

celia-oai force-pushed the dev/cc/refactor branch 3 times, most recently from 96ecaca to d20e87c Compare March 26, 2026 21:31

changes

85d5381

celia-oai force-pushed the dev/cc/refactor branch from d20e87c to 85d5381 Compare March 26, 2026 21:32

chatgpt-codex-connector bot reviewed Mar 26, 2026

View reviewed changes

codex-rs/core/src/config/permissions.rs Outdated Show resolved Hide resolved

codex-rs/config/src/config_requirements.rs Show resolved Hide resolved

celia-oai added 2 commits March 26, 2026 15:13

changes

1a62e67

changes

71c88f9

chatgpt-codex-connector bot reviewed Mar 26, 2026

View reviewed changes

codex-rs/core/src/config/permissions.rs Show resolved Hide resolved

changes

c9abc12

celia-oai force-pushed the dev/cc/refactor branch from 13cb1b6 to c9abc12 Compare March 26, 2026 22:49

viyatb-oai reviewed Mar 27, 2026

View reviewed changes

codex-rs/app-server/src/config_api.rs Show resolved Hide resolved

viyatb-oai reviewed Mar 27, 2026

View reviewed changes

viyatb-oai approved these changes Mar 27, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 27, 2026

📊 AI CLI 工具社区动态日报 2026-03-27 gsscsd/big_model_radar#101

Open

celia-oai added 3 commits March 26, 2026 21:33

changes

f052ee6

changes

d4dd5e1

Merge branch 'main' into dev/cc/refactor

d0f1d86

celia-oai force-pushed the dev/cc/refactor branch from 5a337b6 to d0f1d86 Compare March 27, 2026 05:33

celia-oai enabled auto-merge (squash) March 27, 2026 05:52

celia-oai merged commit dd30c8e into main Mar 27, 2026
36 checks passed

celia-oai deleted the dev/cc/refactor branch March 27, 2026 06:18

github-actions bot locked and limited conversation to collaborators Mar 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: refactor network permissions to use explicit domain and unix socket rule maps#15120

chore: refactor network permissions to use explicit domain and unix socket rule maps#15120
celia-oai merged 11 commits intomainfrom
dev/cc/refactor

celia-oai commented Mar 19, 2026 •

edited

Loading

celia-oai commented Mar 20, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

celia-oai commented Mar 20, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

celia-oai commented Mar 20, 2026

celia-oai commented Mar 26, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

celia-oai commented Mar 26, 2026

celia-oai commented Mar 26, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

viyatb-oai Mar 27, 2026

celia-oai Mar 27, 2026

celia-oai Mar 27, 2026

viyatb-oai Mar 27, 2026

viyatb-oai Mar 27, 2026

Uh oh!

Labels

2 participants

Conversation

celia-oai commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Backward Compatibility

Backward compatible

Not backward compatible

Testing

celia-oai commented Mar 20, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

celia-oai commented Mar 20, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

celia-oai commented Mar 20, 2026

celia-oai commented Mar 26, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

celia-oai commented Mar 26, 2026

celia-oai commented Mar 26, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

viyatb-oai Mar 27, 2026

Choose a reason for hiding this comment

celia-oai Mar 27, 2026

Choose a reason for hiding this comment

celia-oai Mar 27, 2026

Choose a reason for hiding this comment

viyatb-oai Mar 27, 2026

Choose a reason for hiding this comment

viyatb-oai Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Labels

2 participants

celia-oai commented Mar 19, 2026 •

edited

Loading