Remove smart_approvals alias migration#15464
Merged
charley-oai merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Stop rewriting config.toml entries that use the deprecated smart_approvals feature alias. Keep regression tests that assert the alias is ignored in both root and profile scopes. Co-authored-by: Codex <noreply@openai.com>
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the legacy
smart_approvalsconfig migration from core config loading.This change:
smart_approvalsintoguardian_approvalapprovals_reviewer = "guardian_subagent"Verification:
just fmtcargo test -p codex-core smart_approvals_alias_is_ignoredcargo test -p codex-core approvals_reviewer_just argument-comment-lintNotes:
cargo test -p codex-corestill hits an unrelated existing failure intools::js_repl::tests::js_repl_imported_local_files_can_access_repl_globals; the JS REPL kernel exits aftermktempfails under the current environment.Enhancement request: requested cleanup to delete the
smart_approvalsalias migration; no public issue link is available.