app-server: Add back pressure and batching to command/exec#15547
Merged
app-server: Add back pressure and batching to command/exec#15547
command/exec#15547Conversation
owenlin0
reviewed
Mar 23, 2026
| connection_id: ConnectionId, | ||
| notification: ServerNotification, | ||
| ) { | ||
| tracing::trace!("app-server event: {notification}"); |
Collaborator
There was a problem hiding this comment.
nit: if this was just for temporary debugging, can we remove? IIRC we've had issues with noisy trace logs in the past
Collaborator
Author
There was a problem hiding this comment.
it's replicated from existing send_server_notification_to_connections, should I remove it from both?
Collaborator
There was a problem hiding this comment.
ah ok, fine to keep then. seems deliberate
owenlin0
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutgoingMessageSender::send_server_notification_to_connection_and_waitwhich returns only once message is written to websocket (or failed to do so)command/exec, to limit them to at most one message in-memory at a timeThis should make commands execution more robust over high-latency/low-throughput networks