Extract rollout into its own crate by aibrahim-oai · Pull Request #15548 · openai/codex

aibrahim-oai · 2026-03-23T19:44:36Z

move rollout recorder, listing, metadata, policy, session index, and rollout-owned DB code into codex-rollout
keep codex-core behavior intact while renaming the leftover core-only files so the move is obvious in GitHub diffs

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector · 2026-03-24T06:02:01Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Codex <noreply@openai.com>

codex-rs/core/src/lib.rs

codex-rs/core/src/rollout.rs

bolinfest · 2026-03-24T18:11:05Z

codex-rs/core/src/rollout.rs

+use crate::config::Config;
+
+impl codex_rollout::RolloutConfigView for Config {
+    fn codex_home(&self) -> &std::path::Path {


Separately, we should be moving all of these things to AbsolutePathBuf.

bolinfest · 2026-03-24T18:12:01Z

codex-rs/core/src/rollout.rs

@@ -0,0 +1,64 @@
+use crate::config::Config;


Relatedly, will all these re-exports get removed in a mechanical follow-up PR?

codex-rs/rollout/src/lib.rs

bolinfest · 2026-03-24T18:16:21Z

codex-rs/rollout/src/path_utils.rs

+    lower_ascii_path(path)
+}
+
+fn is_wsl_case_insensitive_path(path: &Path) -> bool {


bolinfest · 2026-03-24T18:17:04Z

codex-rs/rollout/src/path_utils.rs

+        && left
+            .iter()
+            .zip(right)
+            .all(|(lhs, rhs)| lhs.to_ascii_lowercase() == *rhs)


shouldn't rhs.to_ascii_lowercase() also?

bolinfest · 2026-03-24T18:18:04Z

codex-rs/rollout/src/path_utils.rs

+}
+
+#[cfg(target_os = "linux")]
+fn lower_ascii_path(path: PathBuf) -> PathBuf {


What is all this? This does not seem right.

bolinfest · 2026-03-24T18:18:47Z

codex-rs/rollout/src/path_utils.rs

+    use std::os::unix::ffi::OsStrExt;
+    use std::os::unix::ffi::OsStringExt;
+
+    let bytes = path.as_os_str().as_bytes();


An OsString is not guaranteed to be UTF-8: we don't know what the encoding is. As such, I don't think this transform is guaranteed to be safe/valid.

bolinfest · 2026-03-24T18:19:18Z

codex-rs/rollout/src/policy.rs

@@ -12,7 +12,7 @@ pub enum EventPersistenceMode {
 /// Whether a rollout `item` should be persisted in rollout files for the
 /// provided persistence `mode`.
 #[inline]


I don't think we should be using #[inline] btw: we should let the compiler do its job.

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai · 2026-03-25T00:30:20Z

@codex review this

chatgpt-codex-connector · 2026-03-25T00:45:04Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from b2a7bb2 to d078760 Compare March 23, 2026 21:54

aibrahim-oai changed the base branch from main to codex/extract-git-utils-crate March 23, 2026 21:54

aibrahim-oai force-pushed the codex/extract-git-utils-crate branch from f9a12b9 to 56b3e16 Compare March 23, 2026 22:03

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch 2 times, most recently from 2c9e147 to 71444ae Compare March 23, 2026 22:30

aibrahim-oai changed the base branch from codex/extract-git-utils-crate to codex/extract-string-truncation-utils March 23, 2026 22:30

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 3464e86 to c62c328 Compare March 23, 2026 23:34

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from 71444ae to ec3c8be Compare March 23, 2026 23:34

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from c62c328 to 5ed93d4 Compare March 23, 2026 23:37

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from ec3c8be to f49d4e3 Compare March 23, 2026 23:38

aibrahim-oai added a commit that referenced this pull request Mar 23, 2026

codex: fix CI failure on PR #15548

a7ec723

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

4eaf95f

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from a7ec723 to 4eaf95f Compare March 24, 2026 00:12

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 9401d05 to b8a17ba Compare March 24, 2026 00:16

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

946e86e

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from 4eaf95f to 946e86e Compare March 24, 2026 00:16

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from b8a17ba to a28046a Compare March 24, 2026 00:22

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

d6a8834

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from 946e86e to d6a8834 Compare March 24, 2026 00:22

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from a28046a to 9e2a887 Compare March 24, 2026 00:34

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

e5c7d3c

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from d6a8834 to e5c7d3c Compare March 24, 2026 00:34

github-actions bot mentioned this pull request Mar 24, 2026

📊 AI CLI 工具社区动态日报 2026-03-24 gsscsd/big_model_radar#86

Open

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 9e2a887 to 8aca7f8 Compare March 24, 2026 01:47

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

6b37ece

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from e5c7d3c to 6b37ece Compare March 24, 2026 01:47

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from 8aca7f8 to fda1492 Compare March 24, 2026 02:05

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

574740e

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from 6b37ece to 574740e Compare March 24, 2026 02:05

aibrahim-oai force-pushed the codex/extract-string-truncation-utils branch from fda1492 to 4bf0fbc Compare March 24, 2026 02:13

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from 32099b9 to db26b6f Compare March 24, 2026 05:49

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

55aa7e7

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from db26b6f to d23ee20 Compare March 24, 2026 06:07

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

a77f8a6

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from d23ee20 to 8091753 Compare March 24, 2026 06:48

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

3f2c17d

Co-authored-by: Codex <noreply@openai.com>

aibrahim-oai force-pushed the codex/extract-rollout-recorder-crate branch from 8091753 to 222118a Compare March 24, 2026 07:00

aibrahim-oai added a commit that referenced this pull request Mar 24, 2026

codex: fix CI failure on PR #15548

4e55c24

Co-authored-by: Codex <noreply@openai.com>

bolinfest reviewed Mar 24, 2026

View reviewed changes

aibrahim-oai and others added 16 commits March 24, 2026 14:34

Move string truncation helpers into codex-utils-string

94b0e35

Co-authored-by: Codex <noreply@openai.com>

Extract rollout into its own crate

b24d7f3

Co-authored-by: Codex <noreply@openai.com>

codex: fix CI failure on PR #15548

6623c52

Co-authored-by: Codex <noreply@openai.com>

codex: fix CI failure on PR #15548

0c2b689

Co-authored-by: Codex <noreply@openai.com>

fix

df2fb2b

Keep truncate_tests module rename

cd07c48

Co-authored-by: Codex <noreply@openai.com>

Merge origin/main into codex/extract-rollout-recorder-crate

6e52dee

Co-authored-by: Codex <noreply@openai.com>

fix

51be026

fix

d70dfd7

fix

7d1a4bd

fix

1bbd4bd

Merge branch 'main' into codex/extract-rollout-recorder-crate

f87f78e

Remove unrelated PR cleanup changes

e10b310

Co-authored-by: Codex <noreply@openai.com>

Revert unrelated tui auth changes

47b533a

Co-authored-by: Codex <noreply@openai.com>

feedback

bd4e057

init

c0d34c8

bolinfest approved these changes Mar 25, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 25, 2026

📊 AI CLI 工具社区动态日报 2026-03-25 gsscsd/big_model_radar#91

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract rollout into its own crate#15548

Extract rollout into its own crate#15548
aibrahim-oai merged 16 commits intomainfrom
codex/extract-rollout-recorder-crate

aibrahim-oai commented Mar 23, 2026

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

Uh oh!

bolinfest Mar 24, 2026

bolinfest Mar 24, 2026

aibrahim-oai Mar 24, 2026

Uh oh!

bolinfest Mar 24, 2026

bolinfest Mar 24, 2026

bolinfest Mar 24, 2026

bolinfest Mar 24, 2026

bolinfest Mar 24, 2026

aibrahim-oai commented Mar 25, 2026

chatgpt-codex-connector bot commented Mar 25, 2026

Labels

2 participants

Conversation

aibrahim-oai commented Mar 23, 2026

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aibrahim-oai commented Mar 25, 2026

chatgpt-codex-connector bot commented Mar 25, 2026

Labels

2 participants