Skip to content

tui_app_server: open ChatGPT login in the local browser#15672

Merged
etraut-openai merged 1 commit intomainfrom
etraut/tui-app-server-login-browser-open
Mar 24, 2026
Merged

tui_app_server: open ChatGPT login in the local browser#15672
etraut-openai merged 1 commit intomainfrom
etraut/tui-app-server-login-browser-open

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Mar 24, 2026

Summary

Fixes ChatGPT login in tui_app_server so the local browser opens again during in-process login flows.

Root cause

The app-server backend intentionally starts ChatGPT login with browser auto-open disabled, expecting the TUI client to open the returned auth_url. The app-server TUI was not doing that, so the login URL was shown in the UI but no browser window opened.

Changes

  • Add a helper that opens the returned ChatGPT login URL locally
  • Call it from the main ChatGPT login flow
  • Call it from the device-code fallback-to-browser path as well
  • Limit auto-open to in-process app-server handles so remote sessions do not try to open a browser against a remote localhost callback
@fcoury
Copy link
Copy Markdown
Contributor

fcoury commented Mar 24, 2026

@etraut-openai looks good!

@etraut-openai etraut-openai merged commit 1b86377 into main Mar 24, 2026
36 checks passed
@etraut-openai etraut-openai deleted the etraut/tui-app-server-login-browser-open branch March 24, 2026 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants