Merged
Conversation
Move contextual user fragment helpers and user instruction payload types into a dedicated crate, and rewire codex-core to consume it. Co-authored-by: Codex <noreply@openai.com>
bolinfest
reviewed
Mar 25, 2026
codex-rs/instructions/src/lib.rs
Outdated
Comment on lines
+6
to
+12
| pub use fragment::AGENTS_MD_END_MARKER; | ||
| pub use fragment::AGENTS_MD_FRAGMENT; | ||
| pub use fragment::AGENTS_MD_START_MARKER; | ||
| pub use fragment::ContextualUserFragmentDefinition; | ||
| pub use fragment::SKILL_CLOSE_TAG; | ||
| pub use fragment::SKILL_FRAGMENT; | ||
| pub use fragment::SKILL_OPEN_TAG; |
Collaborator
There was a problem hiding this comment.
It's hard to verify this without pulling this branch locally, but do all of these constants need to be public? Please restrict the public crate API to the minimum.
bolinfest
approved these changes
Mar 25, 2026
Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
stack/instructions
branch
from
3f18123 to
41c97f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing