[mcp] Improve custom MCP elicitation#15800
Merged
mzeng-openai merged 5 commits intomainfrom Mar 26, 2026
Merged
Conversation
mzeng-openai
commented
Mar 25, 2026
|
|
||
| `turnId` is best-effort. When the elicitation is correlated with an active turn, the request includes that turn id; otherwise it is `null`. | ||
|
|
||
| For MCP tool approval elicitations, form request `meta` includes |
Collaborator
Author
There was a problem hiding this comment.
This is existing behavior for apps/connectors, just adding documentation here.
Collaborator
Author
|
@codex please review |
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c1d37af00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
shijie-oai
reviewed
Mar 25, 2026
shijie-oai
approved these changes
Mar 25, 2026
Collaborator
shijie-oai
left a comment
shijie-oai
left a comment
There was a problem hiding this comment.
LGTM - would like to get some eyes from the agent team. Concern is a) mcp tool approvals for mcps installed from skills and what happens after the user remove the plugin.
owenlin0
reviewed
Mar 25, 2026
owenlin0
approved these changes
Mar 25, 2026
fouad-openai
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.