Skip to content

core: remove special execve handling for skill scripts#15812

Merged
bolinfest merged 1 commit intomainfrom
pr15812
Mar 26, 2026
Merged

core: remove special execve handling for skill scripts#15812
bolinfest merged 1 commit intomainfrom
pr15812

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Mar 25, 2026

Why

We still want general skill support, but we no longer want executables under a skill's scripts/ directory to get bespoke exec approval or escalation behavior.

With this change, intercepted skill scripts follow the same path as other commands, so the turn sandbox and normal exec policy stay in charge. Declared skill permissions in openai.yaml no longer widen execution for scripts/ helpers.

What Changed

  • removed the SkillScript branch, find_skill() lookup, and skill-specific approval wiring from core/src/tools/runtimes/shell/unix_escalation.rs
  • removed the execve session approval cache that only existed for the skill-script path
  • kept general skill support intact; SKILL.md loading and openai.yaml parsing are unchanged
  • replaced the old integration coverage with focused tests that assert declared skill permissions are ignored for script execution and that WorkspaceWrite still blocks out-of-workspace writes under zsh-fork
@bolinfest bolinfest changed the title fix: remove special treatment of scripts/ for a skill Mar 25, 2026
@bolinfest bolinfest merged commit 01fa4f0 into main Mar 26, 2026
36 checks passed
@bolinfest bolinfest deleted the pr15812 branch March 26, 2026 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants