Skip to content

feat: clean spawn v1#15861

Merged
jif-oai merged 1 commit intomainfrom
jif/clean-spawn-v1
Mar 26, 2026
Merged

feat: clean spawn v1#15861
jif-oai merged 1 commit intomainfrom
jif/clean-spawn-v1

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Mar 26, 2026

Avoid the usage of path in the v1 spawn

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Mar 26, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

agent_metadata
.agent_path
.as_ref()
.map(ToString::to_string)
.unwrap_or_else(|| receiver_thread_id.to_string()),

P2 Badge Key wait_agent v1 results by thread ID

Keep v1 wait_agent output keys as IDs. After this change, v1 send_input/close_agent accept only agent IDs and the v1 schema documents ID-keyed statuses, but WaitAgentHandler still prefers agent_metadata.agent_path. If a target has a path (e.g. legacy/named metadata), the model gets /root/... keys and follow-up v1 calls fail with invalid agent id.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 4a5635b into main Mar 26, 2026
33 of 35 checks passed
@jif-oai jif-oai deleted the jif/clean-spawn-v1 branch March 26, 2026 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant