Conversation
aibrahim-oai
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
token_datais owned bycodex-login, butcodex-corewas still re-exporting it. That let callers pull auth token types throughcodex-core, which keeps otherwise unrelated crates coupled tocodex-coreand makescodex-coremore of a build-graph bottleneck.What changed
codex-corere-export ofcodex_login::token_datacodex-coreinternals that usedcrate::token_datato importcodex_login::token_datadirectlycodex-rs/chatgpt,codex-rs/tui_app_server,codex-rs/app-server/tests/common, andcodex-rs/core/teststo importcodex_login::token_datadirectlycodex-loginworkspace dependencies and refresh lock metadata for crates that now depend on it directlyValidation
cargo test -p codex-chatgpt --lockedjust argument-comment-lintjust bazel-lock-updatejust bazel-lock-checkNotes
cargo test -p codex-core --lockedandcargo test -p codex-core auth_refresh --locked, but both ran out of disk while linkingcodex-coretest binaries in the local environment