Conversation
bolinfest
force-pushed
the
pr15918
branch
2 times, most recently
from
9a02418 to
9dfeb92
Compare
Collaborator
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
celia-oai
approved these changes
Mar 27, 2026
| const MACOS_SEATBELT_NETWORK_POLICY: &str = include_str!("seatbelt_network_policy.sbpl"); | ||
| const MACOS_RESTRICTED_READ_ONLY_PLATFORM_DEFAULTS: &str = | ||
| include_str!("restricted_read_only_platform_defaults.sbpl"); | ||
| const MACOS_DEFAULT_PREFERENCES_POLICY: &str = r#"; allow readonly user preferences |
Collaborator
There was a problem hiding this comment.
let's just include this as part of MACOS_SEATBELT_BASE_POLICY?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PermissionProfileshould only describe the per-command permissions we still want to grant dynamically. KeepingMacOsSeatbeltProfileExtensionsin that surface forced extra macOS-only approval, protocol, schema, and TUI branches for a capability we no longer want to expose.What changed
codex-protocol, the app-server v2 API, and the generated schema/TypeScript artifacts.MacOsSeatbeltProfileExtensionsthrough execution requests and seatbelt construction.request_permissionsintersection handling so explicitly empty requested read lists are preserved only when that field was actually granted, avoiding zero-grant responses being stored as active permissions.