[app-server-protocol] introduce generic ClientResponse for app-server-protocol#15921
Merged
[app-server-protocol] introduce generic ClientResponse for app-server-protocol#15921
Conversation
owenlin0
reviewed
Mar 27, 2026
Collaborator
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
can we avoid exporting ClientResponse actually? clients haven't needed it so I think we can avoid the bloat in the generated JSON schema / TypeScript types. Let's just use ClientResponse internally for the analytics wiring
owenlin0
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientResponseas the symmetrical typed response union toClientRequestfor app-server-protocol