Conversation
bolinfest
force-pushed
the
pr15954
branch
3 times, most recently
from
1664d0a to
1dfa6e0
Compare
jif-oai
approved these changes
Mar 27, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
I let the windows part to @iceweasel-oai but the rest is obviously ok for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-utils-ptyandcodex-windows-sandboxwere the remaining crates incodex-rsthat still overrode the workspace's Rust 2024 edition. Moving them forward in a separate PR keeps the baseline edition update isolated from the follow-on Bazel clippy workflow in #15955, while making linting and formatting behavior consistent with the rest of the workspace.This PR also needs Cargo and Bazel to agree on the edition for
codex-windows-sandbox. Without the Bazel-side sync, the experimental Bazel app-server builds fail once they compilewindows-sandbox-rs.What changed
codex-rs/utils/ptyandcodex-rs/windows-sandbox-rstoedition = "2024"codex-utils-ptycallsites and tests to use the collapsedif letform that Clippy expects under the new editionwindows-sandbox-rs, including the reservedgenidentifier,unsafe externrequirements, and new Clippy findings that surfaced under the edition bumpunsafe_op_in_unsafe_fnin the Windows entrypoint modules that now report it under Rust 2024codex-rs/windows-sandbox-rs/BUILD.bazeltocrate_edition = "2024"so Bazel compiles the crate with the same edition as CargoStack created with Sapling. Best reviewed with ReviewStack.