Fix tui_app_server hook notification rendering and replay#16013
Fix tui_app_server hook notification rendering and replay#16013etraut-openai merged 5 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e13b961b92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdbcd2def1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...widget/snapshots/codex_tui_app_server__chatwidget__tests__approvals_selection_popup.snap.new
Show resolved
Hide resolved
2 participants
Addresses #15984
HookStarted/HookCompleted notifications were being translated through a fragile JSON bridge, so hook status/output never reached the renderer. Early hook notifications could also be dropped during session refresh before replay.
This PR fixes
tui_app_serverby mapping app-server hook notifications into TUI hook events explicitly and preserving buffered hook notifications across refresh, so cold-start and resumed sessions render the same hook UI as the legacy TUI.