Skip to content

Fix tui_app_server agent picker closed-state regression#16014

Merged
etraut-openai merged 7 commits intomainfrom
etraut/tuiappserver-agents-regression
Mar 28, 2026
Merged

Fix tui_app_server agent picker closed-state regression#16014
etraut-openai merged 7 commits intomainfrom
etraut/tuiappserver-agents-regression

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Mar 27, 2026

Addresses #15992

The app-server TUI was treating tracked agent threads as closed based on listener-task bookkeeping that does not reflect live thread state during normal thread switching. That caused the /agent picker to gray out live agents and could show a false "Agent thread ... is closed" replay message after switching branches.

This PR fixes the picker refresh path to query the app server for each tracked thread and derive closed vs loaded state from thread/read status, while preserving cached agent metadata for replay-only threads.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d357b1ea2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a80b1a35d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b04b570619

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bolinfest added a commit that referenced this pull request Mar 27, 2026
#15999 introduced a Windows-only `\r\n` mismatch in review-exit template
handling. This PR normalizes those template newlines and separates that
fix from [#16014](#16014) so it can
be reviewed independently.
@etraut-openai etraut-openai force-pushed the etraut/tuiappserver-agents-regression branch from 633bab6 to a55dfe2 Compare March 27, 2026 20:54
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a55dfe2b54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai force-pushed the etraut/tuiappserver-agents-regression branch from 54f120b to cc882e0 Compare March 27, 2026 21:39
@fcoury
Copy link
Copy Markdown
Contributor

fcoury commented Mar 28, 2026

@etraut-openai looks good.

@etraut-openai etraut-openai merged commit ed977b4 into main Mar 28, 2026
38 checks passed
@etraut-openai etraut-openai deleted the etraut/tuiappserver-agents-regression branch March 28, 2026 01:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants