Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This continues the
codex-toolsmigration by moving another passive tool-definition layer out ofcodex-core.After
ResponsesApiTooland the lower-level schema adapters moved intocodex-tools,core/src/client_common.rswas still owningToolSpecand the web-search request wire types even though they are serialized data models rather than runtime orchestration. Keeping those types incodex-coremakes the crate boundary look smaller than it really is and leaves non-runtime tool-shape code coupled to core.What changed
ToolSpec,ResponsesApiWebSearchFilters, andResponsesApiWebSearchUserLocationintocodex-rs/tools/src/tool_spec.rscodex-rs/tools/src/tool_spec_tests.rsfor:ToolSpec::name()ToolSpecserialization forweb_searchandtool_searchcodex-rs/tools/src/lib.rsexports-only by re-exporting the new module fromlib.rscore/src/client_common.rsto a compatibility shim that re-exports the extracted tool-spec types for current core call sitescore/src/tools/spec_tests.rsto consume the extracted web-search types directly fromcodex-toolscodex-rs/tools/README.mdso the crate contract reflects thatcodex-toolsnow owns the passive tool-spec request models in addition to the lower-level Responses API structsTest plan
cargo test -p codex-toolscargo test -p codex-core --lib tools::spec::cargo test -p codex-core --lib client_common::just fix -p codex-tools -p codex-corejust argument-comment-lintReferences