fix: clean up remaining Windows argument-comment-lint violations#16071
Merged
fix: clean up remaining Windows argument-comment-lint violations#16071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The initial
argument-comment-lintrollout left Windows on default-target coverage because there were still Windows-only callsites failing under--all-targets. This follow-up cleans up those remaining Windows-specific violations so the Windows CI lane can enforce the same stricter coverage, leaving Linux as the remaining platform-specific follow-up.What changed
rust-ciargument-comment-lint step back to the default wrapper invocation so it runs full-target coverage again/*param_name*/annotations at Windows-gated literal callsites in:codex-rs/windows-sandbox-rs/src/lib.rscodex-rs/windows-sandbox-rs/src/elevated_impl.rscodex-rs/tui_app_server/src/multi_agents.rscodex-rs/network-proxy/src/proxy.rsValidation
argument comment lintCI on this PR