Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #16130 fixed the Windows
argument-comment-lintregression inrust-ci-full, but the nextmainruns still left the Linux and macOS lint legs timing out.In run 23695263729, both non-Windows
argument-comment-lintjobs were cancelled almost exactly 30 minutes after they started. The remaining workflow difference versusrust-ci.ymlwas thatrust-ci-fulldid not passBUILDBUDDY_API_KEYinto the non-Windows Bazel lint step, sorun-bazel-ci.shfell back to local Bazel configuration instead of using the faster remote-backed path available onmain.What changed
BUILDBUDDY_API_KEYto the non-Windowsrust-ci-fullargument-comment-lintBazel steprust-ci-full.ymlTest plan
.github/workflows/rust-ci-full.ymland.github/workflows/rust-ci.ymlwithpython3+yaml.safe_load(...)23695263729and confirmedArgument comment lint - LinuxandArgument comment lint - macOSwere cancelled about 30 minutes after startrust-ci-fullstep now matches the non-Windows secret wiring already present inrust-ci.ymlReferences