Conversation
dylan-hurd-oai
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
thread_start_params_from_config()is supposed to forward the effectiveapprovals_reviewerinto the app-server request, but these tests were constructing that config throughConfigBuilder::build(), which also loads ambient system and managed config layers. On machines with an admin or host-level reviewer override, the manual-only case could inheritguardian_subagentand fail even though the exec-side mapping was correct.What changed
approvals_reviewerexplicitly viaharness_overridesin the twothread_start_params_*review_policy*tests incodex-rs/exec/src/lib.rs.config.tomlwrites so the tests exercise only the reviewer-to-request mapping incodex-exec.Testing
cargo test -p codex-exec