Skip to content

exec: make review-policy tests hermetic#16137

Merged
bolinfest merged 1 commit intomainfrom
pr16137
Mar 28, 2026
Merged

exec: make review-policy tests hermetic#16137
bolinfest merged 1 commit intomainfrom
pr16137

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Mar 28, 2026

Why

thread_start_params_from_config() is supposed to forward the effective approvals_reviewer into the app-server request, but these tests were constructing that config through ConfigBuilder::build(), which also loads ambient system and managed config layers. On machines with an admin or host-level reviewer override, the manual-only case could inherit guardian_subagent and fail even though the exec-side mapping was correct.

What changed

  • Set approvals_reviewer explicitly via harness_overrides in the two thread_start_params_*review_policy* tests in codex-rs/exec/src/lib.rs.
  • Removed the dependence on default config resolution and temp config.toml writes so the tests exercise only the reviewer-to-request mapping in codex-exec.

Testing

  • cargo test -p codex-exec
@bolinfest bolinfest enabled auto-merge (squash) March 28, 2026 22:59
@bolinfest bolinfest merged commit f7ef959 into main Mar 28, 2026
22 checks passed
@bolinfest bolinfest deleted the pr16137 branch March 28, 2026 23:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants