Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Bump to modern ruby - #1391

Open
CloCkWeRX wants to merge 12 commits into
mainlinefrom
bump-ruby
Open

CloCkWeRX wants to merge 12 commits into
mainlinefrom
bump-ruby

Conversation

@CloCkWeRX

Copy link
Copy Markdown
Contributor

No description provided.

@CloCkWeRX
CloCkWeRX requested a review from RickCarlino March 13, 2023 09:54
@CloCkWeRX

Copy link
Copy Markdown
Contributor Author

@RickCarlino could you... nuke the brakeman scan check as a pre commit hook, as well, it is dead and there's a lot of dependabot security updates pending. (It's making things less secure than more secure)

@CloCkWeRX

Copy link
Copy Markdown
Contributor Author

Alternatively, just merge... #1360

@RickCarlino

Copy link
Copy Markdown
Contributor

Hey @CloCkWeRX this seems like a good idea. I am no longer involved with FarmBot/OpenFarm though so you may want to forward this to @roryaronson or @gabrielburnworth.

@CloCkWeRX

Copy link
Copy Markdown
Contributor Author

@gabrielburnworth; want to try chucking on dependabot, which will chug through and bump a bunch of dependencies?

SyntaxError:
  /home/runner/work/OpenFarm/OpenFarm/vendor/bundle/ruby/3.0.0/gems/mime-types-3.3/lib/mime/types/logger.rb:30: _1 is reserved for numbered parameter

https://github.com/mime-types/ruby-mime-types/blob/main/History.md#331--2019-12-26 fixes this

@CloCkWeRX
CloCkWeRX changed the base branch from mainline to bump-mime-types April 29, 2023 05:42
Base automatically changed from bump-mime-types to mainline April 29, 2023 06:34

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants