Update google-services.json Firebase config and simplify notification null checks#61
Open
Miggets7 wants to merge 1 commit into
Open
Update google-services.json Firebase config and simplify notification null checks#61Miggets7 wants to merge 1 commit into
Miggets7 wants to merge 1 commit into
Conversation
Refresh GenericApp/app/google-services.json toward the current Firebase project (openremoteapp-a6a60): switch storage bucket to the *.firebasestorage.app host. The stale config caused Firebase Installations Service (FIS) auth failures that blocked FCM token retrieval and push delivery on Android. Also simplify null/empty checks in ORFirebaseMessagingService to use isNullOrEmpty(). Refs #60
Miggets7
force-pushed
the
update-google-services-firebase-config
branch
from
b8156b9 to
284f69c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh
GenericApp/app/google-services.jsontoward the current Firebase project (openremoteapp-a6a60), switching the storage bucket to the*.firebasestorage.apphost. The stale config caused Firebase Installations Service (FIS) auth failures that blocked FCM token retrieval and push delivery on Android:Simplify null/empty checks in
ORFirebaseMessagingServiceto useisNullOrEmpty().This is the Android-side follow-up to openremote/openremote#2794 ("Set action on push notification confirm button"), so the confirm-button action actually reaches the device.
Test plan
Related