ref: simplify node occurrence check in validationImpossibleOneway#11943
Open
dipanshurdev wants to merge 1 commit intoopenstreetmap:developfrom
Open
ref: simplify node occurrence check in validationImpossibleOneway#11943dipanshurdev wants to merge 1 commit intoopenstreetmap:developfrom
dipanshurdev wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize node occurrence detection in impossible oneway validation
Improves code efficiency and readability by replacing a manual loop
with native Array methods. The function now uses indexOf/lastIndexOf
comparison to detect duplicate nodes in a way.
Type of Change
Changes
indexOf()andlastIndexOf()comparisonPerformance Impact
Testing