Skip to content

Attempt to get Travis to deploy to npmjs#6457

Merged
acinader merged 3 commits into
masterfrom
travis-busted
Mar 2, 2020
Merged

Attempt to get Travis to deploy to npmjs#6457
acinader merged 3 commits into
masterfrom
travis-busted

Conversation

@acinader

@acinader acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor

Use deprecated skip_cleanup: true
as cleanup: false doesn't
appear to be working

acinader added 2 commits March 2, 2020 10:17
as cleanup: false doesn't
appear to be working
@acinader acinader requested a review from davimacedo March 2, 2020 18:24
@dplewis

dplewis commented Mar 2, 2020

Copy link
Copy Markdown
Member

I think the previous build was good. The release didn't tag properly.

@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

i don't think so. if you expand the deploy step, even though it says it worked, you can see that npm is failing because it doesn't have babel

@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

why do you think it didn't tag properly??

@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

image

@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

image

@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

i'm optimistic that this change will fix it.

@dplewis

dplewis commented Mar 2, 2020

Copy link
Copy Markdown
Member

Do you have a link to that job?

@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author
@acinader

acinader commented Mar 2, 2020

Copy link
Copy Markdown
Contributor Author

your link is to the pr merge, not the new tag.

@dplewis dplewis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acinader acinader merged commit bde8ab6 into master Mar 2, 2020
@TomWFox TomWFox added the release label Mar 2, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Use deprecated skip_cleanup
as cleanup: false doesn't
appear to be working

* prepare release

* revert change to branch
@TomWFox TomWFox deleted the travis-busted branch April 3, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants