LRU perf patches#6007
Draft
polchawa-percona wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: it is PoC - not production ready! and has no support for compressed pages - but should be easy to restore
Recommended to set:
The list of applied patches:
a. grouping pages to evict/flush into tiny batches to reduce number of times the LRU list mutex has to be released and reacquired internally in the loop.
b. preparing a new list of batched free pages outside the free_list mutex section, and then doing O(1) concatenation of lists under the mutex only
Please note that the following two parameters make significant differences for all tested versions in this test:
Especially the innodb_buffer_pool_instances set to higher values, can result in better shape for TPS curve by reducing the LRU list mutex contention further...