Skip to content

fix: correctly handle integer -> bigint conversion #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
levkk merged 2 commits into from
Jan 31, 2026
Merged

fix: correctly handle integer -> bigint conversion #736

levkk merged 2 commits into from
Jan 31, 2026
+735 −222

Conversation

@levkk
Copy link
Collaborator

@levkk levkk commented Jan 31, 2026

Instead of appending ALTER TABLE ... ALTER COLUMN ... TYPE BIGINT, we modify CREATE TABLE statement in-place, changing the column type from integer to bigint, iff the column is part of a primary key constraint.
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 92.66409% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/backend/schema/sync/pg_dump.rs 92.66% 19 Missing ⚠️

📢 Thoughts on this report? Let us know!
@blacksmith-sh

This comment has been minimized.

Sign in to view
@blacksmith-sh

This comment has been minimized.

Sign in to view
@levkk levkk merged commit 6b27caa into main Jan 31, 2026
26 of 32 checks passed
@levkk levkk deleted the levkk-mat-views branch January 31, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@levkk