Skip to content

Fix 7930 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix 7930 #192

wants to merge 2 commits into from

Conversation

@bp1222
Copy link
Contributor

@bp1222 bp1222 commented Feb 22, 2017

Change was proposed, and accepted, via: https://wiki.php.net/rfc/list_reference_assignment
@emilv
Copy link

emilv commented Feb 23, 2017

Neither the RFC nor this PR mentions how this interacts with https://wiki.php.net/rfc/list_keys but your test case in php/php-src#2371 does test for list('one' => &$one, 'two' => $two). Should we add that example? Perhaps ['one' => &$one, 'two' => $two] as well?
@bp1222
Copy link
Contributor Author

bp1222 commented Feb 23, 2017

Yes I can add it to the spec change. Can't believe I forgot to note that in the RFC, it was accounted for during implementation in tests.
@nikic nikic added the RFC label Mar 21, 2017
@bp1222
Copy link
Contributor Author

bp1222 commented Jan 25, 2018

php/php-src#2371 has been merged as php/php-src@6d4de4c. This PR for the langspec is able to be merged at this point to reflect the new syntax.
cmb69
cmb69 reviewed Aug 29, 2018
View reviewed changes
@cmb69
Copy link
Member

cmb69 commented Aug 29, 2018

Thanks! It occurs to me that #221 should be resolved before merging this PR.
@nikic
Copy link
Member

nikic commented Mar 15, 2019

Merged as ee9565c, together with a tweak to the grammar to add the optional &.
@nikic nikic closed this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFC

4 participants

@bp1222 @emilv @cmb69 @nikic