Skip to content

Fix GH-20553: PDO::FETCH_CLASSTYPE ignores $constructorArgs in PHP 8.5.0 #20595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: PHP-8.5
Choose a base branch
from
Open

Fix GH-20553: PDO::FETCH_CLASSTYPE ignores $constructorArgs in PHP 8.5.0 #20595

wants to merge 3 commits into from
+99 −1

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Nov 26, 2025

We must assign the ctor_arguments regardless of modes.

Fix GH-20553
@Girgias Girgias linked an issue Nov 26, 2025 that may be closed by this pull request
PHP 8.5.0 regression: PDO::FETCH_CLASSTYPE ignores $constructorArgs #20553
Open
@Girgias Girgias force-pushed the 8.5-pdo_fetch_class_bug branch from 1fb2007 to 3f8b4a9 Compare November 26, 2025 12:24
@Girgias Girgias marked this pull request as ready for review November 26, 2025 13:21
@Girgias
Copy link
Member Author

Girgias commented Nov 26, 2025

@SakiTakamachi do you know what the FireBird issue is? It seems it doesn't support the SQL query :/
@SakiTakamachi
Copy link
Member

SakiTakamachi commented Nov 26, 2025

@Girgias

I’m not feeling well, so I’ll check this issue once I’ve recovered!
@ndossche
Copy link
Member

ndossche commented Nov 26, 2025 •
edited
Loading

Firebird requires a FROM clause IIRC. So add FROM RDB$DATABASE. (be careful about the dollar tho)
EDIT: well, adding that from RDB$DATABASE won't work for the other databases ofc :P Also I'm not sure you can end with a semicolon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extension: pdo (core)

3 participants

@Girgias @SakiTakamachi @ndossche