Don't invalidate container cache on user-interactions in the shell#4924
Merged
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you! |
SanderMuller
added a commit
to SanderMuller/phpstan-src
that referenced
this pull request
Jun 24, 2026
The container cache key included the entire environment (minus a hand-maintained denylist - phpstan#4924, phpstan#4925), so any unrelated env var that differs between invocations (CI runners inject per-job vars on every run) flipped the key and forced a full container recompile + ignoreErrors re-validation. The container only depends on the environment through (a) %env.X% references in loaded configs and (b) env read at build time by a CompilerExtension (PHPStan reads only PHPSTAN_FNSR, in FnsrExtension::beforeCompile()). Keep exactly those env vars in the cache key - the %env.NAME% names (matching Nette's %([\w.-]*)% grammar) plus self::BUILD_TIME_ENV_VARIABLES - and drop the rest. The container parameters still carry the full env, so %env.*% resolution is unaffected; this only narrows the key. ContainerCacheKeyEnvGuardTest enforces that every env var read at build time by a CompilerExtension is declared, so a future build-time getenv() cannot silently reuse a stale container. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#14072 (comment)
ENV variables used for building the container key sometimes change, based on user interactions in the shell.
it happens after you
cdbetween folders and run PHPStan again.see https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html
I see another case: the container invalidates as soon as you re-size the shell window, because a ENV var exists which defines the LINES and COLUMNS in the window
while I think this is just a workaround for a more general problem - I see no way atm to find out which ENV vars are relevant for us and which are not