Revert recent types #7601
Merged
Revert recent types #7601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR reverts a recent change in texture type annotations by updating their JSDoc comments.
- Reverts the JSDoc type specification in the setter from a union of TEXTURETYPE constants to a generic string.
- Reverts the JSDoc type specification in the getter from a union of TEXTURETYPE constants to a generic string.
Comments suppressed due to low confidence (1)
src/platform/graphics/texture.js:821
- The change in the getter’s JSDoc type annotation to {string} may lead to a loss of descriptive type constraints. Please ensure that this generic type meets all usage requirements or document the change accordingly.
* @type {string}
| @@ -803,7 +803,7 @@ class Texture { | |||
| /** | |||
| * Sets the texture type. | |||
| * | |||
| * @type {TEXTURETYPE_DEFAULT|TEXTURETYPE_RGBM|TEXTURETYPE_RGBE|TEXTURETYPE_RGBP} | |||
| * @type {string} | |||
There was a problem hiding this comment.
Reverting the JSDoc type annotation to {string} removes the explicit union of allowed texture types, potentially reducing clarity for developers. Consider including a comment explaining the rationale behind this change.
Suggested change
| * @type {string} | |
| * @type {'default' | 'rgbm' | 'rgbe' | 'rgbp'} |
Copilot uses AI. Check for mistakes.
willeastcott
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the types change in #7579