Skip to content

Update Concurrent.js - #43

Closed
i-am-the-slime wants to merge 3 commits into
purescript-react:mainfrom
i-am-the-slime:patch-3
Closed

Update Concurrent.js#43
i-am-the-slime wants to merge 3 commits into
purescript-react:mainfrom
i-am-the-slime:patch-3

Conversation

@i-am-the-slime

@i-am-the-slime i-am-the-slime commented Jul 3, 2022

Copy link
Copy Markdown
Member 
✘ [ERROR] The symbol "createRoot" has already been declared

    output/React.Basic.DOM.Concurrent/foreign.js:6:16:
      6 │ export function createRoot(element) {
        ╵                 ~~~~~~~~~~

  The symbol "createRoot" was originally declared here:

    output/React.Basic.DOM.Concurrent/foreign.js:2:6:
      2 │ const createRoot = ReactDOM.createRoot || ReactDOM.unstable_createRoot;
        ╵       ~~~~~~~~~~
@i-am-the-slime

i-am-the-slime commented Jul 3, 2022

Copy link
Copy Markdown
Member Author

Funnily esbuild does not work with server.js but only server because there's a module definition.
@i-am-the-slime
Try something else again
499769f 
Error in Console:
Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".
@andys8

andys8 commented Jul 6, 2022

Copy link
Copy Markdown
Member

Cool, would solve the second issue mentioned in #42 (comment)
@andys8 andys8 mentioned this pull request Jul 7, 2022
Merged
@mjrussell

mjrussell commented Jul 8, 2022

Copy link
Copy Markdown
Member

@i-am-the-slime we can close this now that #44 is merged right?
@i-am-the-slime
i-am-the-slime deleted the patch-3 branch July 8, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@i-am-the-slime @andys8 @mjrussell