Skip to content

Migrate support lib dependencies to AndroidX.#332

Merged
pwittchen merged 1 commit intopwittchen:RxJava2.xfrom
ychescale9:yc/androidx
May 11, 2019
Merged

Migrate support lib dependencies to AndroidX.#332
pwittchen merged 1 commit intopwittchen:RxJava2.xfrom
ychescale9:yc/androidx

Conversation

@ychescale9
Copy link
Contributor

Closes #331

PR migrates support lib to AndroidX:

com.android.support:support-annotations:28.0.0 -> androidx.annotation:annotation:1.0.2
com.android.support:appcompat-v7:28.0.0 -> androidx.appcompat:appcompat:1.0.2

Note that the library itself only depends on the annotation library, appcompat is used by sample app.

The following have also been updated:

  • Kotlin 1.3.31
  • RxJava 2.2.8
  • RxAndroid 2.1.1
@codecov-io
Copy link

Codecov Report

Merging #332 into RxJava2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           RxJava2.x     #332   +/-   ##
==========================================
  Coverage      83.17%   83.17%           
==========================================
  Files             11       11           
  Lines            434      434           
  Branches          33       33           
==========================================
  Hits             361      361           
  Misses            47       47           
  Partials          26       26
Impacted Files Coverage Δ
...n/reactivenetwork/library/rx2/ReactiveNetwork.java 83.33% <ø> (ø) ⬆️
.../strategy/MarshmallowNetworkObservingStrategy.java 100% <ø> (ø) ⬆️
...chen/reactivenetwork/library/rx2/Connectivity.java 68.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2ece2...62d62ac. Read the comment docs.

@pwittchen
Copy link
Owner

Looks reasonable. Thanks! I'll include this change in the next release. :)

@pwittchen pwittchen merged commit cf07132 into pwittchen:RxJava2.x May 11, 2019
@ychescale9 ychescale9 deleted the yc/androidx branch May 12, 2019 02:38
@pwittchen pwittchen mentioned this pull request May 12, 2019
7 tasks
@pwittchen
Copy link
Owner

pwittchen commented May 13, 2019

@ychescale9 this update is available in the latest release 3.0.3

@ychescale9
Copy link
Contributor Author

@pwittchen Thanks! That was quick:)

@pwittchen
Copy link
Owner

That's the way it should be :).

@ychescale9 Just being curious: can you tell me in what app are you using this library or can you send any link here?

@ychescale9
Copy link
Contributor Author

ychescale9 commented Aug 25, 2019

@pwittchen Sorry just noticed your comment after 3 months 😂.

It was a cryptocurrency app (I've now moved on) with support for syncing blockchain data to the mobile client using ElectrumX servers.

ReactiveNetwork was an important piece in our networking stack as we need a stream of Network On / Network Off events for performing health check on our Sync Engine and decides when to retry / re-trigger the next sync etc.

I've also used it in other projects and I love it as it fits well within reactive / push-based architectures. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants