Fix mingw build re atomic functions - #198
Merged
Merged
Conversation
Multiple issues making the build fail: * _InterlockedExchange8 is missing in mingw-w64, filed in mingw-w64/mingw-w64#118 * cffi_atomic_store_ssize is missing casts, leading to errors * __ldar8/__ldar64 are not supported in gcc/clang Just use the builtin compiler intrinsics everywhere for GCC/Clang when targeting Windows. Same as is already done in misc_thread_posix.h See python-cffi#159
Contributor
|
Pending #137 to make the windows CI runs faster, maybe we should add a mingw CI run for a single python version. On the other hand, what is the priority for this compiler? I would expect many mingw users can |
Contributor
Author
|
There is no priority for me at least, I patched it downstream in MSYS2 already. I just had the patch anyway, and saw the issue, so proposed it. There are no compatible binary wheels, so pip always builds from source (and as a result it's not easy/error prone) |
Contributor
|
Thanks @lazka |
Contributor
Author
|
Thanks! |
Contributor
Author
|
Just wondering, is there a release planned which includes this? I would appreciate it :) |
Contributor
|
@nitzmahone any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple issues making the build fail:
Just use the builtin compiler intrinsics everywhere for GCC/Clang when targeting Windows. Same as is already done in misc_thread_posix.h
See #159