Skip to content

gh-105858: Expose some union-related objects as internal APIs#116025

Merged
encukou merged 2 commits intopython:mainfrom
JelleZijlstra:unionapi
Feb 28, 2024
Merged

gh-105858: Expose some union-related objects as internal APIs#116025
encukou merged 2 commits intopython:mainfrom
JelleZijlstra:unionapi

Conversation

@JelleZijlstra
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra commented Feb 28, 2024

We now use these in the AST parsing code after gh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
@JelleZijlstra
Copy link
Copy Markdown
Member Author

This should fix these buildbot failures: #105880 (comment)

I tested locally by running ./python.exe -m test -u cpu test_peg_generator -v.

@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 28, 2024
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 5142722 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 28, 2024
@JelleZijlstra
Copy link
Copy Markdown
Member Author

The macOS builds are failing with something related to 2to3 that doesn't seem due to my changes:

Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.12

To list all files that would be deleted:
  brew link --overwrite python@3.12 --dry-run
@encukou encukou enabled auto-merge (squash) February 28, 2024 09:52
@encukou encukou merged commit d53560d into python:main Feb 28, 2024
@JelleZijlstra JelleZijlstra deleted the unionapi branch February 28, 2024 11:16
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…ythonGH-116025)

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…ythonGH-116025)

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…ythonGH-116025)

We now use these in the AST parsing code after pythongh-105880. A few comparable types (e.g.,
NoneType) are already exposed as internal APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants