gh-100240: Use a consistent implementation for freelists#121934
Conversation
This combines and updates our freelist handling to use a consistent implementation. Objects in the freelist are linked together using the first word of memory block. If configured with freelists disabled, these operations are essentially no-ops.
colesbury
requested review from
Fidget-Spinner,
corona10,
ericsnowcurrently and
markshannon
|
I'm putting this up for discussion and feedback. @markshannon, this doesn't do all the things listed in the issue -- I haven't In my limited testing, I haven't seen a significant performance difference. |
|
Perfomance is in the noise but doesn't look like it's any worse. |
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Very nice. +290 −700 had me sold 🙂
A lot of compiler warnings, but should be fixable with one cast in the _Py_FREELIST_SIZE macro.
Consider it approved once the macro is fixed.
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
Awesome!
Consider it approved once the macro is fixed.
Same opinion :)
Co-authored-by: Mark Shannon <mark@hotpy.org>
|
!buildbot AMD64 Ubuntu NoGIL Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit aa8e4d5 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
4 participants
This combines and updates our freelist handling to use a consistent implementation. Objects in the freelist are linked together using the first word of memory block.
When Python is configured to build without freelists, these operations are essentially no-ops.