Skip to content

bpo-1635741: Port _crypt extension module to multiphase initialization(PEP 489) #18404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Feb 7, 2020

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #18404 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18404       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.07%     
===========================================
  Files        1955     1570      -385     
  Lines      588851   414397   -174454     
  Branches    44428    44429        +1     
===========================================
- Hits       483552   344761   -138791     
+ Misses      95647    59991    -35656     
+ Partials     9652     9645        -7     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 440 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d892...2572432. Read the comment docs.

@shihai1991
Copy link
Member Author

@vstinner @ncoghlan @encukou Hi, folks. About porting extension module to pep-489, some extension module have no maintainer or non-active maintainer. So I invite petr(as pep-489 author)、nick(as pep-489 author) and victor(as performance master) help me review a serious of PRs :)

@vstinner vstinner merged commit b2b6e27 into python:master Feb 17, 2020
@vstinner
Copy link
Member

Thanks, merged.

@shihai1991
Copy link
Member Author

thanks, victor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants