Skip to content

bpo-1635741: convert an _lsprof method to argument clinic #22240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Sep 14, 2020

@koubaa
Copy link
Contributor Author

koubaa commented Sep 14, 2020

@vstinner Please review, this will be the first stage from #22220

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please remove the NEWS entry.

@@ -0,0 +1,2 @@
Convert the getstats method of the :mod:`_lsprof` extension module to
argument clinic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the NEWS entry, it's not worth it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner done

@koubaa koubaa force-pushed the bpo-1635741-lsprof-clinic branch from bdd6c25 to c32f5b7 Compare September 21, 2020 12:03
@vstinner vstinner merged commit 1b328ea into python:master Sep 21, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants