Skip to content

bpo-1635741: Fix _struct for build bot error #23402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

bpo-1635741: Fix _struct for build bot error #23402

merged 1 commit into from
Nov 19, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 19, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran
@corona10 corona10 requested a review from tiran November 19, 2020 13:52
@tiran
Copy link
Member

tiran commented Nov 19, 2020

Thanks, you were faster than me.
@corona10
Copy link
Member Author

@tiran I was panicked at the first time ;)
vstinner
vstinner approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ah, it seems like only big endian architectures are affected, that's why the typo was not spotted by CIs run on the merged PR.
@miss-islington
Copy link
Contributor

@corona10: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 588c7c9 into python:master Nov 19, 2020
@corona10 corona10 deleted the gh-23398-fix branch November 19, 2020 14:15
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-1635741: Fix _struct for build bot error (pythonGH-23402)
dfd7d1c 
Automerge-Triggered-By: GH:tiran
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news
6 participants
@corona10 @tiran @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot