Skip to content

bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec - #31475

Merged
corona10 merged 3 commits into
python:mainfrom
corona10:bpo-46541-multibytecodec
Mar 1, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec#31475
corona10 merged 3 commits into
python:mainfrom
corona10:bpo-46541-multibytecodec

Conversation

@corona10

@corona10 corona10 commented Feb 21, 2022

Copy link
Copy Markdown
Member
Comment thread Modules/cjkcodecs/multibytecodec.c Outdated
@terryjreedy

terryjreedy commented Feb 21, 2022

Copy link
Copy Markdown
Member

In the issue number, 65 was transposed as 56. Fixed.

@terryjreedy terryjreedy changed the title bpo-45641: Remove usage of _Py_IDENTIFIER from multibytecodec Feb 21, 2022

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Modules/cjkcodecs/multibytecodec.c Outdated
@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from tiran February 28, 2022 09:08
@corona10

corona10 commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

After some discussion, I decided to merge this PR anyway.
I will accept the other approach if someone wants :) I hope that this approach would help to reduce the usage of private APIs
cc @ericsnowcurrently, @erlend-aasland, @tiran, @vstinner (alphabetical order :)

@corona10
corona10 merged commit 0cc6364 into python:main Mar 1, 2022
@corona10
corona10 deleted the bpo-46541-multibytecodec branch March 1, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

7 participants