bpo-27923: Minor API improvements for binary sequences (PEP 467) #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we generally put in a PendingDeprecationWarning when the alternative syntax is not available in still supported versions of Python or is going all the way to DeprecationWarning immediately the normal way of doing things? The new syntax is great, but I'd prefer not to need to do a version test/fork as long as <= Py3.6 is still supported by my modules and while PendingDeprecationWarnings are fine, I try not to have DeprecationWarnings in code I release. |
|
So... what else needs to be done for this change to be approved? Does someone need to merge it? |
methane
added
DO-NOT-MERGE
type-feature
|
This PR is stale because it has been open for 30 days with no activity. |
erlend-aasland
added
the
pending
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing this, as the linked issue has been closed. |
erlend-aasland
removed
the
pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically my original attempt to implement PEP 467, with some minor changes to make it work with Python 3.7.
https://bugs.python.org/issue27923