Attempt to fix bool re-narrowing - #11845
Closed
sobolevn wants to merge 3 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
For some reason all builds with mypyc-compiled mypy fail. While regular tests pass. No idea why. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Ok, I will try something else. |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: graphql-core (https://github.com/graphql-python/graphql-core)
+ tests/type/test_definition.py:1115: error: Argument 1 to "isnan" has incompatible type "None"; expected "Union[SupportsFloat, SupportsIndex]"
+ tests/language/test_visitor.py:73: error: Value of type "Node" is not indexable
zulip (https://github.com/zulip/zulip)
+ zerver/lib/events.py:495: error: Statement is unreachable [unreachable]
+ zerver/lib/events.py:513: error: Statement is unreachable [unreachable]
+ zerver/lib/events.py:534: error: Statement is unreachable [unreachable]
+ zerver/lib/events.py:600: error: Statement is unreachable [unreachable]
+ zerver/tests/test_events.py:495: error: Statement is unreachable [unreachable]
core (https://github.com/home-assistant/core)
- homeassistant/config_entries.py:474: error: Returning Any from function declared to return "bool" [no-any-return]
|
Member
Author
|
See #11839 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see what mypy_primer and CI will say.
Closes #11839
Refs #10389