Apply feedback: Change MAYBE_UNRECOGNIZED_STR_TYPEFORM from unaccompa…

…nied note to standalone error

docs/source/error_code_list.rst

@@ -1313,31 +1313,31 @@ by mypy in the following locations:
 
 If you try to use a string annotation in some other location
 which expects a TypeForm, the string value will always be treated as a ``str``
-even if a ``TypeForm`` would be more appropriate and this note code
+even if a ``TypeForm`` would be more appropriate and this error code
 will be generated:
 
 .. code-block:: python
 
-   # Note: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize.  [maybe-unrecognized-str-typeform]
+   # Error: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize.  [maybe-unrecognized-str-typeform]
    # Error: List item 0 has incompatible type "str"; expected "TypeForm[Any]"  [list-item]
    list_of_typx: list[TypeForm] = ['str | None', float]
 
-Fix the note by surrounding the entire type with ``TypeForm(...)``:
+Fix the error by surrounding the entire type with ``TypeForm(...)``:
 
 .. code-block:: python
 
    list_of_typx: list[TypeForm] = [TypeForm('str | None'), float]  # OK
 
 Similarly, if you try to use a string literal in a location which expects a
-TypeForm, this note code will be generated:
+TypeForm, this error code will be generated:
 
 .. code-block:: python
 
    dict_of_typx = {'str_or_none': TypeForm(str | None)}
-   # Note: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize.  [maybe-unrecognized-str-typeform]
+   # Error: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize.  [maybe-unrecognized-str-typeform]
    list_of_typx: list[TypeForm] = [dict_of_typx['str_or_none']]
 
-Fix the note by adding ``# type: ignore[maybe-unrecognized-str-typeform]``
+Fix the error by adding ``# type: ignore[maybe-unrecognized-str-typeform]``
 to the line with the string literal:
 
 .. code-block:: python

mypy/checkexpr.py

@@ -6358,7 +6358,7 @@ def try_parse_as_type_expression(self, maybe_type_expr: Expression) -> Type | No
         # don't try to parse it because there isn't enough information
         # available to the TypeChecker pass to resolve string annotations
         if has_str_expression(maybe_type_expr):
-            self.chk.note(
+            self.chk.fail(
                 "TypeForm containing a string annotation cannot be recognized here. "
                 "Surround with TypeForm(...) to recognize.",
                 maybe_type_expr,

mypy/errorcodes.py

@@ -273,7 +273,7 @@ def __hash__(self) -> int:
 METACLASS: Final[ErrorCode] = ErrorCode("metaclass", "Ensure that metaclass is valid", "General")
 MAYBE_UNRECOGNIZED_STR_TYPEFORM: Final[ErrorCode] = ErrorCode(
     "maybe-unrecognized-str-typeform",
-    "Warn when a string is used where a TypeForm is expected but a string annotation cannot be recognized",
+    "Error when a string is used where a TypeForm is expected but a string annotation cannot be recognized",
     "General",
 )
 

mypy/errors.py

@@ -26,7 +26,6 @@
 SHOW_NOTE_CODES: Final = {
     codes.ANNOTATION_UNCHECKED,
     codes.DEPRECATED,
-    codes.MAYBE_UNRECOGNIZED_STR_TYPEFORM,
 }
 
 # Do not add notes with links to error code docs to errors with these codes.

test-data/unit/check-typeform.test

@@ -218,15 +218,15 @@ dict_with_typx_keys[int | str] += 1
 [case testTypeExpressionWithStringAnnotationNotRecognizedInOtherSyntacticLocations]
 # flags: --python-version 3.14 --enable-incomplete-feature=TypeForm
 from typing import Dict, List, TypeForm
-list_of_typx: List[TypeForm] = ['int | str']  # N: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
+list_of_typx: List[TypeForm] = ['int | str']  # E: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
                                               # E: List item 0 has incompatible type "str"; expected "TypeForm[Any]"
 dict_with_typx_keys: Dict[TypeForm, int] = {
-    'int | str': 1,  # N: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
+    'int | str': 1,  # E: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
                      # E: Dict entry 0 has incompatible type "str": "int"; expected "TypeForm[Any]": "int"
-    'str | None': 2,  # N: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
+    'str | None': 2,  # E: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
                       # E: Dict entry 1 has incompatible type "str": "int"; expected "TypeForm[Any]": "int"
 }
-dict_with_typx_keys['int | str'] += 1  # N: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
+dict_with_typx_keys['int | str'] += 1  # E: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
                                        # E: Invalid index type "str" for "dict[TypeForm[Any], int]"; expected type "TypeForm[Any]"
 [builtins fixtures/dict.pyi]
 [typing fixtures/typing-full.pyi]
@@ -235,10 +235,10 @@ dict_with_typx_keys['int | str'] += 1  # N: TypeForm containing a string annotat
 from typing import Any, Dict, List, TypeForm
 types: Dict[str, TypeForm] = {'any': Any}
 # Ensure warning can be ignored if does not apply.
-list_of_typx1: List[TypeForm] = [types['any']]  # N: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize.
+list_of_typx1: List[TypeForm] = [types['any']]  # E: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize.
 list_of_typx2: List[TypeForm] = [types['any']]  # type: ignore[maybe-unrecognized-str-typeform]
 # Ensure warning can be fixed using the suggested fix in the warning message.
-list_of_typx3: List[TypeForm] = ['Any']  # N: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
+list_of_typx3: List[TypeForm] = ['Any']  # E: TypeForm containing a string annotation cannot be recognized here. Surround with TypeForm(...) to recognize. \
                                          # E: List item 0 has incompatible type "str"; expected "TypeForm[Any]"
 list_of_typx4: List[TypeForm] = [TypeForm('Any')]
 [builtins fixtures/dict.pyi]