Fix inconsistent strict_optional documentation#21661
Open
BHUVANSH855 wants to merge 1 commit into
Open
Conversation
A5rocks
suggested changes
Jul 1, 2026
A5rocks
left a comment
A5rocks
left a comment
Collaborator
There was a problem hiding this comment.
Sorry but this docs change is kind of nonsensical.
BHUVANSH855
force-pushed
the
fix-21658-strict-optional-docs
branch
from
4e830ea to
fbf67f7
Compare
A5rocks
approved these changes
Jul 1, 2026
A5rocks
left a comment
A5rocks
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. @95-martin-orion what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the inconsistent description of
strict_optionalin the documentation.Changes
strict_optional = trueenables checking of optional types andNonevalues.strict_optional = falsedisables that checking.strict_optionaland--no-strict-optionalwarnings to the "Optional types and the None type" documentation for additional context.Fixes #21658