fix: run version compatibility check with the resolved API key credentials#132
Merged
Anush008 merged 4 commits intoJun 23, 2026
Merged
Conversation
The checkCompatibility health check in Builder.build() used this.callCredentials, which withApiKey() no longer populates since the custom-headers refactor (49e4826, released in 1.18.0): the api key MetadataCredentials are only constructed after the check runs. Against an auth-required server (e.g. Qdrant Cloud) the check therefore ran unauthenticated and logged "Failed to obtain server version", re-introducing qdrant#96. Resolve the effective call credentials before running the check and pass them in. Add a regression test asserting the check receives the api key credentials. Fixes qdrant#131
Member
|
Thanks for taking the time to contribute @jamesm6162 |
Anush008
reviewed
Jun 23, 2026
Anush008
reviewed
Jun 23, 2026
Co-authored-by: Anush <mail@anush.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131
Problem
When credentials are set via
withApiKey(...), thecheckCompatibilityhealth check inbuild()runs unauthenticated and logs"Failed to obtain server version"against auth-required servers (e.g. Qdrant Cloud). This regressed #96 (fixed in #97) starting in1.18.0: the custom-headers refactor (49e4826) changedwithApiKey()to defer buildingMetadataCredentialsuntil after the compatibility check, so the check saw a nullcallCredentials.Fix
Resolve the effective
CallCredentials(explicitcallCredentials, otherwise fromapiKey/headers) before the compatibility check, and pass them intocheckVersionsCompatibility(...). No public API change.Test
Adds
QdrantGrpcClientCompatibilityTest(uses the already-declaredmockito-core, no live server required). It mocks the gRPC stub and assertsbuild()invokes the version check with the non-nullMetadataCredentialsderived fromwithApiKey(...). Verified that the test fails against the pre-fix code and passes with the fix.