Skip to content

zsh: rework ZSH completion#30

Open
vincentbernat wants to merge 1 commit intoqrush:masterfrom
vincentbernat:fix/zsh-completion
Open

zsh: rework ZSH completion#30
vincentbernat wants to merge 1 commit intoqrush:masterfrom
vincentbernat:fix/zsh-completion

Conversation

@vincentbernat
Copy link
Copy Markdown

The completion for ZSH is upgraded to the new ZSH completion
system. To work, the file should be placed somewhere in ZSH fpath to
be autoloaded when needed and named _sub.

There are other embedded misc changes:

  • $CURRENT indicate which word is being autocompleted.
  • In ZSH, automatic word splitting is disabled in completion. There
    is no need to quote words.

The completion also handles plugins that are able to complete
args. However, most plugins don't and will complete with a subcommand
instead. I don't think there is an universal solution for this.

I am no ZSH wizard. Take this commit with care (works for me).

The completion for ZSH is upgraded to the new ZSH completion
system. To work, the file should be placed somewhere in ZSH fpath to
be autoloaded when needed and named `_sub`.

There are other embedded misc changes:
 - `$CURRENT` indicate which word is being autocompleted.
 - In ZSH, automatic word splitting is disabled in completion. There
   is no need to quote words.
@mislav
Copy link
Copy Markdown

mislav commented Dec 19, 2012

Looks good!

@markstos
Copy link
Copy Markdown
Contributor

markstos commented Jun 2, 2023

I'm not a ZSH user, but given that @mislav seems to have peer-reviewed this, I recommend merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants